feat: updating setup script to use orbit sdk #72
feat: updating setup script to use orbit sdk #72GreatSoshiant wants to merge 14 commits intomainfrom
Conversation
scripts/transferOwnership.ts
Outdated
| l3Provider: ethers.providers.JsonRpcProvider, | ||
| childChainRpc: string |
There was a problem hiding this comment.
I think l3Provider includes the RPC URL in the object, can you verify? In that case we wouldn't need the last parameter.
There was a problem hiding this comment.
No JsonRpcProvider doesn't have any method to get rpc url which is weird haha
https://docs.ethers.org/v5/api/providers/jsonrpc-provider/
There was a problem hiding this comment.
I think you can get it from l3Provider.connection.url. Just did a quick test, but verify on your end 🙏
|
The script works and files are much cleaner now, thanks @GreatSoshiant ! |
TucksonDev
left a comment
TucksonDev
left a comment
There was a problem hiding this comment.
Thanks very much @GreatSoshiant !
There's one minor comment pending, but this LGTM 🚀
2 participants
Closes: INT-136